Re: Discussion about iopa()
From: Dan Malek <hidden>
Date: 2007-02-10 18:04:05
On Feb 9, 2007, at 9:37 PM, Benjamin Herrenschmidt wrote:
We are fairly careful about not bloating fast path in general.
This isn't any fast path code, and the way the exception handlers are growing it doesn't seem to be a concern anyway.
.... It's more than a couple of memory accesses, especially with PTEs in highmem where it involves kmap.
It is only a couple of memory accesses, even less code than the TLB exception handlers. Using highmem has a price any time it's configured into a system, it's not unique in this case. In fact, in this case highmem shouldn't be a concern any different than the TLB exceptions. I just don't understand how such a trivial and useful function that does exactly what we need in a very clean way generates so much polarized discussion. I'm beginning to think it's just personal, since the only argument against it is "I don't like it" when the alternatives are just hacks at best that still need to be "fixed up someday." :-) The Linux VM implementation just sucks. The majority of systems running this software aren't servers and desktop PCs, it's embedded SOCs with application specific peripherals. They have attributes and are mapped in ways that don't fit the "memory at 0" or "IO" model. We have to find solutions to this, together. Thanks. -- Dan