Re: [PATCH 04/10] powermac: clean up PIC initialisation code

On Thu, 2007-02-08 at 15:41 +1100, Paul Mackerras wrote:

Johannes Berg writes:

quoted

This patch cleans up the powermac PIC initialisation code so that for G5
powermacs we don't even compile the old pmac pic file.

On a 32-bit powermac config, with this patch I get:

  CC      arch/powerpc/platforms/powermac/mpic.o
/home/paulus/kernel/powerpc/arch/powerpc/platforms/powermac/mpic.c: In function ‘pmac_pic_setup_mpic_nmi’:
/home/paulus/kernel/powerpc/arch/powerpc/platforms/powermac/mpic.c:40: error: ‘xmon_action’ undeclared (first use in this function)
/home/paulus/kernel/powerpc/arch/powerpc/platforms/powermac/mpic.c:40: error: (Each undeclared identifier is reported only once
/home/paulus/kernel/powerpc/arch/powerpc/platforms/powermac/mpic.c:40: error: for each function it appears in.)
make[3]: *** [arch/powerpc/platforms/powermac/mpic.o] Error 1

Yeah. I noticed that yesterday as well, but too late. Sorry about that.
I could fix but it isn't nice, let's just drop this patch instead.
Sorry.

johannes