Thread (2 messages) flat view 2 messages, 2 authors, 2007-01-20

Re: [PATCH] # ppc: ppc4xx_set_src/dst_addr were only correct for DMA0

From: Roger Larsson <hidden>
Date: 2007-01-20 13:39:33

On Saturday 20 January 2007 00:02, Niklaus Giger wrote:
DCRN_DMASAH0 + dmanr*2
to
DCRN_DMASAH0 + dmanr * 0x8
Wouln't it be possible to give DCRN_DMASAH0 such an type that
DCRN_DMASAH0 + dmanr
would do? Or even better
DCRN_DMASAH[dmanr]

BTW this code looks suspicious, how will the 64BIT dma
ever work? Only highest 32 bits are stored...

PPC should really try to move toward the generic interface...

/RogerL
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help