Re: [PATCH 7/19] powerpc: interfaces to the hypervisor of Celleb

Hello everyone,

quoted

Just a few suggestions.

Thank you for your comments.

quoted

quoted

+#define	   HCALL_MEDIUM	or	2,2,2

Doesnt look like this is used.

seconded.  that #define is identical to HMT_MEDIUM out of ppc_asm.h.  I
notice that HMT_MEDIUM is actually used throughout this patch, so most
of the way there already.

We'll remove it.

<asm/ppc_asm.h> is already included so we don't have to have
HMT_MEDIUM or HCALL_MEDIUM defintion in that file.

quoted

quoted

+#define		   HVSC	     .long   0x44000022

Could you pick this up from the define in include/asm-powerpc instead?

"#include <asm/hvcall.h>" should do it.

As Geoff-san said, "sc 1" is not supported in Debian or our own assembler,
so we have to keep it.

We think <asm/hvcall.h> is only for IBM's hypervisor, so we don't want
to include <asm/hvcall.h> only to get HVSC definition in our hvCall.S;
so we will keep HVSC definition here.

quoted

quoted

+#define	LOAD_CONST64(r, const)					\
+		lis		r, ((const)>>48)&0xFFFF;				\
+		ori		r, r, ((const)>>32)&0xFFFF;						\
+		rldicr		r, r, 32, 31;										  \
+		oris		r, r, ((const)>>16)&0xFFFF;								    \
+		ori		r, r, ((const)>>0)&0xFFFF

It doesnt look like this is used either.

We'll remove it.

Best regards,
Kou Ishizaki