Re: [PATCH 7/19] powerpc: interfaces to the hypervisor of Celleb

On Sat, 2007-13-01 at 23:46 +1100, Anton Blanchard wrote:

Hi,

Just a few suggestions.

quoted

+#define	HCALL_MEDIUM	or 	2,2,2

Doesnt look like this is used.

seconded.  that #define is identical to HMT_MEDIUM out of ppc_asm.h.  I
notice that HMT_MEDIUM is actually used throughout this patch, so most
of the way there already.

quoted

+#define	HVSC	.long	0x44000022

Could you pick this up from the define in include/asm-powerpc instead?

"#include <asm/hvcall.h>" should do it.

quoted

+#define	LOAD_CONST64(r, const)					\
+	lis	r, ((const)>>48)&0xFFFF;			\
+	ori	r, r, ((const)>>32)&0xFFFF;			\
+	rldicr	r, r, 32, 31;					\
+	oris	r, r, ((const)>>16)&0xFFFF;			\
+	ori	r, r, ((const)>>0)&0xFFFF

It doesnt look like this is used either.

Anton
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev