Re: [PATCH] powerpc: consolidate mpc83xx platform files
From: Kumar Gala <hidden>
Date: 2006-12-13 00:23:28
From: Kumar Gala <hidden>
Date: 2006-12-13 00:23:28
On Dec 12, 2006, at 4:40 PM, Scott Wood wrote:
Kumar Gala wrote:quoted
What's the issue with a file per board if all it has is the ppc_md/ define_machine() in it. Someone explain to me why this is a bad thing?It requires that the kernel be changed even when a new board doesn't require that the kernel actually *do* anything differently. It's gratuitous duplication, even if the bit being duplicated is small.
But at least someone had to think about the duplication and it provides remove for customization if its needed in the future.
Why is a single ppc_md, which no board is forced to use, but can be used by any board without special requirements, a bad thing?
It adds code to all those people that don't need it just so we don't duplicate a few lines of source code. - k