Re: [linux-usb-devel] [PATCH 1/2] Fixed compiled issue tu to new of_platform.h header

On Thursday 23 November 2006 8:12 am, nd@bplan-gmbh.de wrote:

 drivers/usb/host/ohci-ppc-of.c |  285 ++++++++++++++++++++++++++++++++++++++++

You've split one "add new bus glue" patch into two ... please
do it the normal way, as one patch!

(Oh, I see you did that the next day.  The next two comments
still apply.)

+ * Store this function in the HCD's struct pci_driver as probe().

You should remove irrelevant/ancient comments like this.  Looks
like you cloned the PCI bus glue and didn't update key parts...

+ */
+static int usb_hcd_ppc_of_probe(const struct hc_driver *driver,
+			  struct of_device *dev, int is_bigendian)

I'm not sure why you didn't just have ohci_hcd_ppc_of_drv_probe()
do all this stuff; there's no point in splitting that code into
two chunks.

Likewise, ohci_hcd_ppc_of_drv_remove() shouldn't be split in two.