Re: [PATCH 1/2] Fixed compiled issue tu to new of_platform.h header

On Sat, 25 Nov 2006, Benjamin Herrenschmidt wrote:

Now, Nico, since the patch has obviously a problem (thouh the problem
might be generic to the way the USB code handles multiple versions of an
HCI), it cannot be merged as-is of course.

Alan, what is your approach there ? We can't have multiple module_init()
in a single file it seems... the ugly fix is to have one with a serie of
#ifdef calling into the various HCI's but that's a big horrid.

I haven't been following this very closely.  The problem is that you have 
a system with two different kinds of OHCI controllers, thus requiring two 
different and incompatible versions of the driver?

If the only source of incompatibility is the module_init() and 
module_exit() routines, then your suggestion would be a simple fix.  
Ugly, yes, but I don't think anyone will really mind.

Is there anything else to prevent you from combining multiple HCIs into a
single driver?

Alan Stern