Thread (33 messages) flat view 33 messages, 5 authors, 2007-03-07

Re: [PATCH 01/22] powerpc: convert idle_loop to use hard_irq_disable()

From: Arnd Bergmann <arnd@arndb.de>
Date: 2006-11-21 10:14:55
Also in: lkml

On Tuesday 21 November 2006 01:53, Benjamin Herrenschmidt wrote:
+
+=A0=A0=A0=A0=A0=A0=A0/*
+=A0=A0=A0=A0=A0=A0=A0 * We need to hard disable interrupts, but we also =
need to mark them
+=A0=A0=A0=A0=A0=A0=A0 * hard disabled in the PACA so that the local_irq_=
enable() done by
+=A0=A0=A0=A0=A0=A0=A0 * our caller upon return propertly hard enables.
+=A0=A0=A0=A0=A0=A0=A0 */
+=A0=A0=A0=A0=A0=A0=A0hard_irq_disable();
+=A0=A0=A0=A0=A0=A0=A0get_paca()->hard_enabled =3D 0;
+
Yes, this looks good. Paul, please use this patch instead of mine.
Do we need to do the same thing for any of the other power_save functions?
IIRC, all new CPUs are supposed to use the same mechanism based on the
0x100 vector.

	Arnd <><
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help