On Oct 30, 2006, at 11:25 PM, Li Yang-r58472 wrote:

quoted

-----Original Message-----
From: Kumar Gala [mailto:galak@kernel.crashing.org]
Sent: Tuesday, October 31, 2006 1:06 PM
To: Li Yang-r58472
Cc: Paul Mackerras; linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] qe_lib: Remove immrbar_virt_to_phys() function


On Oct 30, 2006, at 8:56 PM, Li Yang-r58472 wrote:

quoted

quoted

quoted

quoted

I'm confused, if there are other users of immrbar_virt_to_phy()

how

quoted

quoted

quoted

quoted

quoted

can you get ride of it completely?

Other users will change to use iopa() instead.  There was some bug

to

quoted

quoted

use iopa() with io_block_mapping area, but it is ok to use it now.

Hmm, what are the other users doing?  I think we should avoid using
iopa.

Get physical address from virtual address.  I have considered to use
virt_to_phys(), but it is not consistent between ppc and powerpc

arch.

quoted

Why does that matter, qe support only exists in powerpc.

Well, it does use include/asm-ppc/io.h instead of
include/asm-powerpc/io.h for now.  If the hack is removed, the driver
will not work.

What uses asm-ppc/io.h instead of asm-powerpc/io.h?

- k