On Oct 30, 2006, at 12:22 AM, Li Yang-r58472 wrote:

quoted

-----Original Message-----
From: Paul Mackerras [mailto:paulus@samba.org]
Sent: Monday, October 30, 2006 11:22 AM
To: Li Yang-r58472
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] qe_lib: Remove immrbar_virt_to_phys() function

Li Yang writes:

quoted

Remove private physical address mapping routine in qe_lib.  Users
of qe_lib should use generic functions like iopa().
The change also addresses a bug found by Timur Tabi that cmd_input
got mapped in qe_issue_cmd().  It should be written to CECDR
unmodified.

Do you mean that the argument to qe_issue_cmd is a physical address?
It seems to me that the bug fix you mention is the main thing the
patch does, and the removal of immrvar_virt_to_phys is a cleanup on
the side that is made possible by the bugfix.

The argument cmd_input should be offset to the MURAM base.  The  
cleanup
is inspired by the bugfix but not result of the bugfix.  There are  
still
other users of the immrbar_virt_to_phy() which can be replaced.  The
bugfix can be covered by the work of removing all users of the  
routine.
Or the removal will be depending on the bugfix to complete its  
work.  Do
you suggest us to separate the patches?

I'm confused, if there are other users of immrbar_virt_to_phy() how  
can you get ride of it completely?

I would suggest just sending the bugfix so it can go in for 2.6.19  
and we can do the cleanup after that.

- kumar