Re: [PATCH] enable RTAS /proc for PowerPC/CHRP platform

On Wed, Oct 18, 2006 at 07:51:52AM +0200, Nicolas DET wrote:

Christoph Hellwig wrote:

quoted

quoted

--- a/arch/powerpc/kernel/rtas-proc.c    2006-10-14 

05:34:03.000000000 +0200

quoted

quoted

+++ b/arch/powerpc/kernel/rtas-proc.c    2006-10-16 

10:46:16.000000000 +0200

quoted

quoted

@@ -253,43 +253,70 @@ static void get_location_code(struct seq
 static void check_location_string(struct seq_file *m, char *c);
 static void check_location(struct seq_file *m, char *c);

+#ifdef CONFIG_PPC64
+#define PROCRTAS_ROOT "ppc64"
+#else
+#define PROCRTAS_ROOT "ppc"

Please don't do any pathname changes.  Even if ppc64 isn't correct it's
what applications expect and what we should provide for a coherent user
interface.

Humm, ok.
However, in this case 'ppc' (could be 32 or 64 as it is not specified) 
is more generic than 'ppc64'.

Christoph, Nicolas, ...

What about doing the logical thing, and switching it to "powerpc" like the
recent arch change, or more logically, to "power" like the current rebranding
of the whole thing ?

I suppose we can also provide some symlinking or similar for compatibility ?
Or move the whole stuff under /sys/.../power/rtas ? 

Friendly,

Sven Luther