Re: [PATCH 12/16] cell: add temperature to SPU and CPU sysfs entries
From: Heiko Carstens <hidden>
Date: 2006-10-25 08:00:53
Also in:
lkml
On Tue, Oct 24, 2006 at 06:31:25PM +0200, arnd@arndb.de wrote:
+ * (C) Copyright IBM Deutschland Entwicklung GmbH 2005
IBM Corp. instead of IBM DE? 2006?
+static int __init thermal_init(void)
+{
+ init_default_values();
+
+ spu_add_sysdev_attr_group(&spu_attribute_group);
+ cpu_add_sysdev_attr_group(&ppe_attribute_group);
+
+ return 0;
+}Same here: check for errors on spu_add_sysdev_attr_group and cpu_add_sysdev_attr_group.
+static void __exit thermal_exit(void)
+{
+ spu_remove_sysdev_attr_group(&spu_attribute_group);
+ cpu_remove_sysdev_attr_group(&ppe_attribute_group);Will crash if cpu_add_sysdev_attr_group failed...