Re: [PATCH]: PCI Error Recovery: Symbios SCSI device driver

On Fri, Sep 22, 2006 at 04:39:29PM -0700, Randy.Dunlap wrote:

On Fri, 22 Sep 2006 18:32:35 -0500 Linas Vepstas wrote:

quoted

On Sat, Sep 23, 2006 at 12:06:29AM +0200, Luca wrote:

quoted

Space after function name? You put in other places too, it's not
consistent with the rest of the patch.

Oops. I was also coding on a different project recently, with a
different style.  I'll send a revised patch in a moment.

Please change if()'s to use

	if (var == constant)
instead of
	if (constant == var)

Yuck! Horrid coding style! No rational excuse for coding like that.
Advice taken under protest; new patch shortly.

--linas