On Fri, 22 Sep 2006 18:32:35 -0500 Linas Vepstas wrote:

On Sat, Sep 23, 2006 at 12:06:29AM +0200, Luca wrote:

quoted

Space after function name? You put in other places too, it's not
consistent with the rest of the patch.

Oops. I was also coding on a different project recently, with a
different style.  I'll send a revised patch in a moment.

Please change if()'s to use

	if (var == constant)
instead of
	if (constant == var)

also.  (or whatever condition is being used)  Thanks.

quoted

quoted

+       if (pci_enable_device(pdev))
+               printk (KERN_ERR "%s: device setup failed most egregiously\n",
+                           sym_name(np));

Is the failure of pci_enable_device ignored on purpose?

No. :-( Thanks for the catch. I think I got cross-eyed staring at the code.

---
~Randy