RE: [PATCH 4/6] ehea: header files

On Tue, 2006-08-15 at 13:07 +0200, Christoph Raisch wrote:

"Jenkins, Clive" wrote on 15.08.2006 12:53:05:

quoted

quoted

quoted

You mean the eHEA has its own concept of page size? Separate from

the

quoted

quoted

page size used by the MMU?

yes, the eHEA currently supports only 4K pages for queues

In that case, I suggest use the kernel's page size, but add a
compile-time
check, and quit with an error message if driver does not support it.

eHEA does support other page sizes than 4k, but the HW interface expects to
see 4k pages
The adaption is done in the device driver, therefore we have a seperate 4k
define.

Fair enough. You seem to only use it in drivers/net/ehea/ehea_qmr.c, if
so put the definition in there, that way someone is less likely to use
the EHEA_PAGESIZE definition where they really need PAGE_SIZE.

cheers

-- 
Michael Ellerman
IBM OzLabs

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person