Re: [PATCH 4/6] ehea: header files

On Wednesday 09 August 2006 10:39, Jan-Bernd Themann wrote:

+extern int ehea_trace_level;
+
+#ifdef EHEA_NO_EDEB
+#define EDEB_P_GENERIC(level, idstring, format, args...) \
+=A0=A0=A0=A0=A0=A0=A0while (0 =3D=3D 1) { \
+=A0=A0=A0=A0=A0=A0=A0 =A0 =A0if(unlikely (level <=3D ehea_trace_level)) =

{ \

+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0pri=

ntk("%s " idstring " "format "\n", \

+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=

=A0=A0=A0=A0=A0=A0=A0__func__, ##args); \

+=A0=A0=A0=A0=A0=A0=A0 =A0} \
+=A0=A0=A0=A0=A0=A0=A0} \
+
+#else
+
+#define EDEB_P_GENERIC(level,idstring,format,args...) \
+if (level < KEEP_EDEBS_BELOW) { \
+=A0=A0=A0=A0=A0=A0=A0do { \
+=A0=A0=A0=A0=A0=A0=A0 =A0 =A0if(unlikely (level <=3D ehea_trace_level)) =

{ \

+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0pri=

ntk("%s " idstring " "format "\n", \

+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=

=A0=A0=A0=A0=A0=A0=A0__func__, ##args); \

+=A0=A0=A0=A0=A0=A0=A0 =A0} \
+=A0=A0=A0=A0=A0=A0=A0} while (1 =3D=3D 0); \
+}
+#endif
+
+#define EDEB(level, format, args...) \
+ =A0 =A0 =A0 =A0EDEB_P_GENERIC(level, "", format, ##args)
+
+#define EDEB_ERR(level, format, args...) \
+ =A0 =A0 =A0 =A0EDEB_P_GENERIC(level, "EHEA_ERROR", format, ##args)
+
+#define EDEB_EN(level, format, args...) \
+ =A0 =A0 =A0 =A0EDEB_P_GENERIC(level, ">>>", format, ##args)
+
+#define EDEB_EX(level, format, args...) \
+ =A0 =A0 =A0 =A0EDEB_P_GENERIC(level, "<<<", format, ##args)

Please don't invent your own debugging macros. You can either use the
pr_debug/pr_info facility from <linux/kernel.h> or get rid of those
completely. The latter is probably preferred for most of your calls.

	Arnd <><