Re: [PATCH 5/10 v2] Add 8641 CPU and i8259 Setup

On Fri, 2006-06-09 at 11:05, Jon Loeliger wrote:

quoted

quoted

+	bl	clear_bats
 	bl	load_up_mmu

Why do you need to call clear_bats here ? load_up_mmu should load BATs.
If it doesn't handle the high BATs, then fix it :) 

Ben,

This line item has finally come around on the guitar!
And I have a question for you... 

How come this additional clear_bats call isn't seen
as a generic fix?  It is possible that the bootloader
has left some crufty (high) BATs hanging around.

Or are you suggesting just adding something like:

    li r10, 0
    mtspr SPRN_DBATxU,r10
    mtspr SPRN_DBATxL,r10

for x in (4 .. 7) to the tail end of load_up_mmu as
the general fix?

Thanks,
jdl