Re: [PATCH] powerpc: whitespace cleanup in reg.h
From: Olof Johansson <hidden>
Date: 2006-05-10 03:14:10
On Tue, May 09, 2006 at 01:34:36PM -0500, jschopp wrote:
quoted
+#define SPRN_HID6 0x3F9 /* BE HID 6 */ +#define HID6_LB (0x0F<<12) /* Concurrent Large Page Modes */ +#define HID6_DLP (1<<20) /* Disable all large page modes (4K only) */ +#define SPRN_TSC_CELL 0x399 /* Thread switch control on Cell */ +#define TSC_CELL_DEC_ENABLE_0 0x400000 /* Decrementer Interrupt */ +#define TSC_CELL_DEC_ENABLE_1 0x200000 /* Decrementer Interrupt */ +#define TSC_CELL_EE_ENABLE 0x100000 /* External Interrupt */ +#define TSC_CELL_EE_BOOST 0x080000 /* External Interrupt Boost */ +#define SPRN_TSC 0x3FD /* Thread switch control on others */ +#define SPRN_TST 0x3FC /* Thread switch timeout on others */OK, the tab to space for lines like SPRN_HID6 I understand. But then you seem to be trying to do indenting with 3 spaces instead of tabs.
It's what the rest of the file uses. It might not correspond to CodingStyle, but it makes it easy to read. (Now, I'm not sure it's a good idea to define the meanings of HID bits in the global register include, but that's unrelated to the whitespace cleanup Mikey did.) -Olof