Thread (33 messages) flat view 33 messages, 6 authors, 2006-05-23

Re: [PATCH 4/6] Have x86_64 use add_active_range() and free_area_init_nodes

From: Andrew Morton <hidden>
Date: 2006-05-20 22:54:34
Also in: linux-mm, lkml

Andi Kleen [off-list ref] wrote:
 
quoted
Well, it creates arch-neutral common code, teaches various architectures
use it.  It's the sort of thing we do all the time.

These things are opportunities to eliminate crufty arch code which few
people understand and replace them with new, clean common code which lots
of people understand.  That's not a bad thing to be doing.
I'm not fundamentally against that, but so far it seems to just generate lots of 
new bugs?  I'm not sure it's really worth the pain.
It is a bit disproportionate.  But in some ways that's a commentary on the
current code.   All this numa/sparse/flat/discontig/holes-in-zones/
virt-memmap/ stuff is pretty hairy, especially in its initalisation.

I'm willing to go through the pain if it ends up with something cleaner
which more people understand a little bit.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help