Thread (8 messages) 8 messages, 5 authors, 2005-12-04

Re: [PATCH] include/asm-ppc/btext.h: add prototype of btext_init function.

flat view

From: Eugene Surovegin <hidden>
Date: 2005-12-04 00:12:07

On Sat, Dec 03, 2005 at 04:00:20PM -0800, Andrew Morton wrote:
Eugene Surovegin [off-list ref] wrote:
quoted
 > +extern void __init btext_init(boot_infos_t *bi);
 >  extern void btext_welcome(void);
 >  extern void btext_prepare_BAT(void);
 >  extern void btext_setup_display(int width, int height, int depth, int pitch,

 "__init" should be placed between closing brace and semicolon. For 
 more info, see include/linux/init.h
I don't think it matters much.  Often we just omit it from the declaration
- it's only required at the definition site
Quite likely it doesn't matter, but I think we should follow existing 
style, if not for correctness, but at least for consistency (it 
actually caught my eye exactly because it _looked_ different). I'm 
pretty sure original poster have tested original version :).

-- 
Eugene
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help