From: Otavio Salvador <hidden> Date: 2005-12-03 19:07:08
The prototype of btext_init function was missing and then caused a compile
warning.
---
include/asm-ppc/btext.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
applies-to: 60e8ae37378de2772b6b0768b12a49f923710152
786b869f9cfd4c1f82fbc8b20fa8cafb9188e12f
On Sat, Dec 03, 2005 at 05:07:06PM -0200, Otavio Salvador wrote:
quoted hunk
The prototype of btext_init function was missing and then caused a compile
warning.
---
include/asm-ppc/btext.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
applies-to: 60e8ae37378de2772b6b0768b12a49f923710152
786b869f9cfd4c1f82fbc8b20fa8cafb9188e12f
From: Otavio Salvador <hidden> Date: 2005-12-03 21:30:25
Eugene Surovegin [off-list ref] writes:
...
quoted
+extern void __init btext_init(boot_infos_t *bi);
...
"__init" should be placed between closing brace and semicolon. For
more info, see include/linux/init.h
Ok. Thanks, I'll resend the patch.
--
O T A V I O S A L V A D O R
---------------------------------------------
E-mail: otavio@debian.org UIN: 5906116
GNU/Linux User: 239058 GPG ID: 49A5F855
Home Page: http://www.freedom.ind.br/otavio
---------------------------------------------
"Microsoft gives you Windows ... Linux gives
you the whole house."
From: Otavio Salvador <hidden> Date: 2005-12-03 21:33:16
The prototype of btext_init function was missing and then caused a compile
warning.
---
include/asm-ppc/btext.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
applies-to: 60e8ae37378de2772b6b0768b12a49f923710152
19174aa31fd85e4410e99deb82c3b7ff2424fa55
From: Andrew Morton <hidden> Date: 2005-12-04 00:00:36
Eugene Surovegin [off-list ref] wrote:
> +extern void __init btext_init(boot_infos_t *bi);
> extern void btext_welcome(void);
> extern void btext_prepare_BAT(void);
> extern void btext_setup_display(int width, int height, int depth, int pitch,
"__init" should be placed between closing brace and semicolon. For
more info, see include/linux/init.h
I don't think it matters much. Often we just omit it from the declaration
- it's only required at the definition site
On Sat, Dec 03, 2005 at 04:00:20PM -0800, Andrew Morton wrote:
Eugene Surovegin [off-list ref] wrote:
quoted
> +extern void __init btext_init(boot_infos_t *bi);
> extern void btext_welcome(void);
> extern void btext_prepare_BAT(void);
> extern void btext_setup_display(int width, int height, int depth, int pitch,
"__init" should be placed between closing brace and semicolon. For
more info, see include/linux/init.h
I don't think it matters much. Often we just omit it from the declaration
- it's only required at the definition site
Quite likely it doesn't matter, but I think we should follow existing
style, if not for correctness, but at least for consistency (it
actually caught my eye exactly because it _looked_ different). I'm
pretty sure original poster have tested original version :).
--
Eugene
> +extern void __init btext_init(boot_infos_t *bi);
> extern void btext_welcome(void);
> extern void btext_prepare_BAT(void);
> extern void btext_setup_display(int width, int height, int depth, int pitch,
"__init" should be placed between closing brace and semicolon. For
more info, see include/linux/init.h
I don't think it matters much. Often we just omit it from the declaration
- it's only required at the definition site
IIRC, on Alpha it's needed/recommended on both, to allow the compiler to
optimize jumps to the same section?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds