Re: RFC: cpm2_devices.c
From: Kumar Gala <hidden>
Date: 2005-06-16 15:33:28
Dan, If I understand you correctly this is not any different than how we handle the TSEC (gianfar) on 85xx. The platform device structure just gives us physical address (start & end) and IRQs and we use a structure in the driver that maps to the start address. - kumar
Having just converted an different SoC part from using offsets to data structures, I have to say that tables/defines of offsets are more of a mess than a data structure. We don't have to define the whole of the IMMAP, but using the data structures for the individual device spaces is quite effective. The advantage of using the data structure is it also conveys the data type size, adding a level error checking. I also dislike io accessor functions/macros, especially on these processor specific devices. Thanks. -- Dan