Re: RFC: cpm2_devices.c
From: Kumar Gala <hidden>
Date: 2005-06-15 14:29:41
quoted
I'm trying to stay away from basing things on the structure. Since the offsets are truly fixed I see not reason to try to make sure that the immap structure is always correct for all cases. Hopefully this will end up removing the need to ifdef the immap structure as we go forward.I am not sure I understand the purpose of each access method. How is the immap structure used vs. the platform resources list? Going half way without a clear distinction of purpose will just confuse the matter. (my opinion)
Agreed, I guess what I mean is going forward drivers should contain their own structure defn.
quoted
pq2_* instead of mpc82xx_ (8240/1/5 is not handled here) or cpm2_ (85xx has cpm2).I used the name CPM2 because that is how all the files are now renamed. Based on the #ifdef in your patch, you can see that 82xx and 83xx use the same device definitions. Lets change the name.
Sure but... I'll change the file names to pq2_ which is what makes the most sense at the end of they. - kumar