Re: PPC uImage build not reporting correctly

On Mon, May 09, 2005 at 10:19:01AM -0500, Kumar Gala wrote:

On May 6, 2005, at 6:22 PM, [off-list ref] wrote:

quoted

On Fri, 6 May 2005, Kumar Gala wrote:

quoted

I tried the following w/o success:

$(obj)/uImage: $(obj)/vmlinux.gz
???????? $(Q)rm -f $@
???????? $(call if_changed,uimage)
???????? @echo '? Image: $@' $(shell if [ -f $@ ]; then echo 'is 

ready'; else

quoted

echo 'not made'; fi)

Couldn't you eliminate the ($shell ..) construct altogether, like 
this?:

$(obj)/uImage: $(obj)/vmlinux.gz
??????? $(Q)rm -f $@
??????? $(call if_changed,uimage)
??????? @echo -n '? Image: $@'
??????? @if [ -f $@ ]; then echo 'is ready' ; else echo 'not made'; fi

Yes, and this seems to actually work.

Sam, does this look reasonable to you.  If so I will work up a patch.

Looks ok - but I do not see why use of $(shell ...) did not work out.
Please bring your working version forward.

	Sam