Thread (4 messages) flat view 4 messages, 3 authors, 2005-05-11

Re: PPC uImage build not reporting correctly

From: Kumar Gala <hidden>
Date: 2005-05-09 15:19:20
Also in: lkml

On May 6, 2005, at 6:22 PM, [off-list ref] wrote:
On Fri, 6 May 2005, Kumar Gala wrote:
 > I tried the following w/o success:
 >
quoted
$(obj)/uImage: $(obj)/vmlinux.gz
=A0=A0=A0=A0=A0=A0=A0=A0 $(Q)rm -f $@
 >=A0=A0=A0=A0=A0=A0=A0=A0 $(call if_changed,uimage)
quoted
=A0=A0=A0=A0=A0=A0=A0=A0 @echo '=A0 Image: $@' $(shell if [ -f $@ ]; =
then echo 'is=20
ready'; else
 > echo 'not made'; fi)

Couldn't you eliminate the ($shell ..) construct altogether, like=20
this?:

$(obj)/uImage: $(obj)/vmlinux.gz
=A0=A0=A0=A0=A0=A0=A0 $(Q)rm -f $@
 =A0=A0=A0=A0=A0=A0=A0 $(call if_changed,uimage)
=A0=A0=A0=A0=A0=A0=A0 @echo -n '=A0 Image: $@'
 =A0=A0=A0=A0=A0=A0=A0 @if [ -f $@ ]; then echo 'is ready' ; else echo =
'not made'; fi

Yes, and this seems to actually work.

Sam, does this look reasonable to you.  If so I will work up a patch.

thanks

- kumar
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help