Re: [PATCH] CPM2 cleanups

Jason, why did you bother to implement these functions, they dont=20
provide any value for us?

It looks like startup() & shutdown() are only used in IRQ probing code=20=

or code in which enable/disable will be used instead.

- kumar

On Mar 22, 2005, at 3:18 PM, Wolfgang Denk wrote:

In message [ref] you wrote:
 >
...
 > +static unsigned int cpm2_startup_irq(unsigned int irq)
 > +{=A0

quoted

+=A0=A0=A0=A0=A0=A0 cpm2_unmask_irq(irq);
+=A0=A0=A0=A0=A0=A0 return 0;

 > +}
 > +
 > +static void cpm2_shutdown_irq(unsigned int irq)
 > +{
 > +=A0=A0=A0=A0=A0=A0 cpm2_mask_irq(irq);

quoted

+}

Why is cpm2_startup_irq() not void like cpm2_shutdown_irq() ?

Best regards,

Wolfgang Denk

--=20
Software Engineering:=A0 Embedded and Realtime Systems,=A0 Embedded =

Linux

 Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
 Overflow on /dev/null, please empty the bit bucket.
 _______________________________________________
Linuxppc-embedded mailing list
 Linuxppc-embedded@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-embedded