In message [off-list ref] you wrote:
...
quoted hunk
+static unsigned int cpm2_startup_irq(unsigned int irq)
+{
+ cpm2_unmask_irq(irq);
+ return 0;
+}
+
+static void cpm2_shutdown_irq(unsigned int irq)
+{
+ cpm2_mask_irq(irq);
+}
Why is cpm2_startup_irq() not void like cpm2_shutdown_irq() ?
Best regards,
Wolfgang Denk
--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Overflow on /dev/null, please empty the bit bucket.
Jason, why did you bother to implement these functions, they dont=20
provide any value for us?
It looks like startup() & shutdown() are only used in IRQ probing code=20=
or code in which enable/disable will be used instead.
- kumar
On Mar 22, 2005, at 3:18 PM, Wolfgang Denk wrote:
In message [off-list ref] you wrote:
>
...
> +static unsigned int cpm2_startup_irq(unsigned int irq)
> +{=A0quoted
+=A0=A0=A0=A0=A0=A0 cpm2_unmask_irq(irq);
+=A0=A0=A0=A0=A0=A0 return 0;
> +}
> +
> +static void cpm2_shutdown_irq(unsigned int irq)
> +{
> +=A0=A0=A0=A0=A0=A0 cpm2_mask_irq(irq);quoted
+}
Why is cpm2_startup_irq() not void like cpm2_shutdown_irq() ?
Best regards,
Wolfgang Denk
--=20
Software Engineering:=A0 Embedded and Realtime Systems,=A0 Embedded =
Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Overflow on /dev/null, please empty the bit bucket.
_______________________________________________
Linuxppc-embedded mailing list
Linuxppc-embedded@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-embedded
On Tue, 2005-03-22 at 23:46 -0600, Kumar Gala wrote:
Jason, why did you bother to implement these functions, they dont
provide any value for us?
It looks like startup() & shutdown() are only used in IRQ probing code
or code in which enable/disable will be used instead.
startup/shutdown is used in the 'IRQ threads' patch we use at
TimeSys.
--
Jason McMullan [off-list ref]
TimeSys Corporation