Thread (1 message) 1 message, 1 author, 2000-03-15
  • (off-list ancestor, not in this archive)
  • Re: dmasound split · Michael Schmitz <hidden> · 2000-03-15

Re: dmasound split

From: Michael Schmitz <hidden>
Date: 2000-03-15 20:15:29

quoted
quoted
No comments whether it works on PowerMac and Atari?
Ah, right.  I tried it out on a 9600 and it worked, and seemingly better than
before (no loud hiss when insmod'ed).  Only sugjestion I would make is to
follow the trend of drivers/XXX/bigdriver/xxx.c instead of dmasound_*.c
Wonderfull. Usually drivers don't work anymore when you split them in parts,
while the split dmasound seems to work better than the old one on both PowerMac
and Amiga :-)
Untested yet on the Lombard, but here's another small patch (to get it
cmpiled in, not as a module).

	Michael
--- drivers/sound/dmasound_core.c.org	Wed Mar 15 21:14:14 2000
+++ drivers/sound/dmasound_core.c	Wed Mar 15 21:12:34 2000
@@ -1357,7 +1357,9 @@

 EXPORT_SYMBOL(dmasound);
 EXPORT_SYMBOL(dmasound_init);
+#ifdef MODULE
 EXPORT_SYMBOL(dmasound_deinit);
+#endif
 EXPORT_SYMBOL(dmasound_write_sq);
 #ifdef HAS_RECORD
 EXPORT_SYMBOL(dmasound_read_sq);

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help