Thread (30 messages) 30 messages, 1 author, 6d ago
COOLING6d

[PATCH 00/29] ibmvfc: Add NVMe-FC support

From: Tyrel Datwyler <tyreld@linux.ibm.com>
Date: 2026-06-23 01:30:50
Also in: linux-scsi, lkml

This patch series adds NVMe-FC protocol support to the ibmvfc driver,
enabling IBM POWER virtual Fibre Channel adapters to handle both SCSI
and NVMe storage traffic through a unified driver architecture.

The implementation leverages the existing multi-queue infrastructure
and extends the driver's protocol handling to support NVMe-FC alongside
traditional SCSI FCP. Key architectural changes include:

- Refactoring the driver into protocol-agnostic core (ibmvfc-core.c)
  and protocol-specific modules (ibmvfc-nvme.c for NVMe-FC)
- Extending the target discovery and management state machine to handle
  NVMe/FC targets with appropriate protocol-specific login sequences
- Implementing the nvme-fc LLDD (Low-Level Device Driver) callbacks for
  queue management, command submission, and abort handling
- Adding support for NVMe-FC specific MAD (Management Adapter Data)
  operations including target discovery, port login, process login,
  and implicit logout/move login
- Implementing NVMe FCP and Link Services (LS) command submission and
  abort paths using the existing sub-CRQ infrastructure

The series is organized to introduce changes incrementally:

Patches 1-8: Infrastructure and refactoring
- Move target lists to protocol-specific channel groups
- Split NVMe support into separate source file
- Add protocol interface definitions and helper functions
- Initialize NVMe channel configuration

Patches 9-16: NVMe/FC MAD operations and target management
- Implement discovery, port login, process login, query target
- Add target allocation based on protocol
- Update state machine for NVMe/FC target processing
- Handle NVMe/FC target deletion

Patches 17-20: Local and remote port registration
- Implement nvme-fc local port registration after fabric login
- Process NVMe/FC rports in work thread
- Extend debug visibility for NVMe components

Patches 21-26: LLDD callback implementation
- Implement queue mapping callbacks
- Add LS and FCP command submission paths
- Implement NVMe FCP and LS abort handling

Patches 27-29: Error handling and debugging
- Fail NVMe requests during transport reset


Tyrel Datwyler (29):
  ibmvfc: move target list from host to protocol specific channel groups
  ibmvfc: add NVMe/FC protocol interface definitions
  ibmvfc: split NVMe support into separate source file and add transport
    stubs
  ibmvfc: initialize NVMe channel configuration during driver probe
  ibmvfc: alloc/dealloc sub-queues for nvme channels
  ibmvfc: add logic for protocol specific fabric logins
  ibmvfc: add wrapper to get vhost associated with a channel struct
  ibmvfc: add helper for creating protocol specific discovery event
  ibmvfc: add helper to check NVMe/FC support with active channels
  ibmvfc: allocate and free NVMe channel group discover buffer
  ibmvfc: send NVMe target discovery MAD
  ibmvfc: add NVMe/FC Implicit Logout and Move Login support
  ibmvfc: add NVMe/FC Port Login support
  ibmvfc: add NVMe/FC Process Login support
  ibmvfc: add NVMe/FC Query Target support
  ibmvfc: allocate targets based on protocol
  ibmvfc: delete NVMe/FC targets as well as SCSI
  ibmvfc: update state machine to process NVMe/FC targets
  ibmvfc: implement NVMe/FC stubs for local/remote port registration
  ibmvfc: register local nvme fc port after fabric login
  ibmvfc: process NVMe/FC rports in work thread
  ibmvfc: extend ibmvfc_debug visibility to ibmvfc-nvme.h
  ibmvfc: declare global function definitions
  ibmvfc: implement LLDD callbacks for mapping nvme-fc queues
  ibmvfc: implement nvme-fc LS submission transport callback
  ibmvfc: implement nvme-fc IO command submission callback
  ibmvfc: implement nvme-fc LS abort handling callback
  ibmvfc: implement nvme-fc FCP abort callback
  ibmvfc: fail nvme-fc fcp-io and ls requests during transport reset

 drivers/scsi/ibmvscsi/Makefile                |   2 +
 .../scsi/ibmvscsi/{ibmvfc.c => ibmvfc-core.c} | 709 ++++++++++++++----
 drivers/scsi/ibmvscsi/ibmvfc-nvme.c           | 565 ++++++++++++++
 drivers/scsi/ibmvscsi/ibmvfc-nvme.h           |  48 ++
 drivers/scsi/ibmvscsi/ibmvfc.h                | 209 +++++-
 5 files changed, 1360 insertions(+), 173 deletions(-)
 rename drivers/scsi/ibmvscsi/{ibmvfc.c => ibmvfc-core.c} (89%)
 create mode 100644 drivers/scsi/ibmvscsi/ibmvfc-nvme.c
 create mode 100644 drivers/scsi/ibmvscsi/ibmvfc-nvme.h

-- 
2.54.0

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help