Re: Update: RE: G4 + Linux + PCI device + x86 driver = 0

Hi Geert,

On   5 Dec, this message from Geert Uytterhoeven echoed through cyberspace:

quoted

David pointed out le16_to_cpu() et al; personally, I use in_/out_le32
et al for access to PCI memory space like this:

out_le32 (&device->register, val);

Which is wrong! Portable PCI memory space accesses must be done using
{read,write}[bwl]()!

Ooopppss.... Thanks for letting me know. I guess it doesn't make much
difference, because the code I use it in is purely PowerMac, but
anyway... I'll go read...

See linux/Documentation/IO-mapping.txt 

....that ;-)

Michel

-------------------------------------------------------------------------
Michel Lanners                 |  " Read Philosophy.  Study Art.
23, Rue Paul Henkes            |    Ask Questions.  Make Mistakes.
L-1710 Luxembourg              |
email   mlan@cpu.lu            |
http://www.cpu.lu/~mlan        |                     Learn Always. "


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/