Re: [PATCH 03/21] block: Add bio_for_each_folio_all()

[PATCH 00/21] iomap/xfs folio patches · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-11-01
[PATCH 01/21] fs: Remove FS_THP_SUPPORT · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-11-01
Re: [PATCH 01/21] fs: Remove FS_THP_SUPPORT · Christoph Hellwig <hch@infradead.org> · 2021-11-02
[PATCH 02/21] block: Add bio_add_folio() · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-11-01
Re: [PATCH 02/21] block: Add bio_add_folio() · Jens Axboe <axboe@kernel.dk> · 2021-11-01
Re: [PATCH 02/21] block: Add bio_add_folio() · Matthew Wilcox <willy@infradead.org> · 2021-11-02
Re: [PATCH 02/21] block: Add bio_add_folio() · Christoph Hellwig <hch@infradead.org> · 2021-11-02
RE: [PATCH 02/21] block: Add bio_add_folio() · wangjianjian (C) <hidden> · 2021-11-03
Re: [PATCH 02/21] block: Add bio_add_folio() · Matthew Wilcox <willy@infradead.org> · 2021-11-03
[PATCH 03/21] block: Add bio_for_each_folio_all() · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-11-01
Re: [PATCH 03/21] block: Add bio_for_each_folio_all() · Jens Axboe <axboe@kernel.dk> · 2021-11-01
Re: [PATCH 03/21] block: Add bio_for_each_folio_all() · Christoph Hellwig <hch@infradead.org> · 2021-11-02
Re: [PATCH 03/21] block: Add bio_for_each_folio_all() · Matthew Wilcox <willy@infradead.org> · 2021-11-02
Re: [PATCH 03/21] block: Add bio_for_each_folio_all() · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-02
Re: [PATCH 03/21] block: Add bio_for_each_folio_all() · Jens Axboe <axboe@kernel.dk> · 2021-11-02
Re: [PATCH 03/21] block: Add bio_for_each_folio_all() · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-02
[PATCH 04/21] iomap: Convert to_iomap_page to take a folio · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-11-01
Re: [PATCH 04/21] iomap: Convert to_iomap_page to take a folio · Christoph Hellwig <hch@infradead.org> · 2021-11-02
[PATCH 05/21] iomap: Convert iomap_page_create to take a folio · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-11-01
Re: [PATCH 05/21] iomap: Convert iomap_page_create to take a folio · Christoph Hellwig <hch@infradead.org> · 2021-11-02
[PATCH 06/21] iomap: Convert iomap_page_release to take a folio · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-11-01
[PATCH 07/21] iomap: Convert iomap_releasepage to use a folio · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-11-01
Re: [PATCH 07/21] iomap: Convert iomap_releasepage to use a folio · Christoph Hellwig <hch@infradead.org> · 2021-11-02
Re: [PATCH 07/21] iomap: Convert iomap_releasepage to use a folio · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-02
[PATCH 08/21] iomap: Add iomap_invalidate_folio · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-11-01
Re: [PATCH 08/21] iomap: Add iomap_invalidate_folio · Christoph Hellwig <hch@infradead.org> · 2021-11-02
Re: [PATCH 08/21] iomap: Add iomap_invalidate_folio · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-02
[PATCH 09/21] iomap: Pass the iomap_page into iomap_set_range_uptodate · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-11-01
Re: [PATCH 09/21] iomap: Pass the iomap_page into iomap_set_range_uptodate · Christoph Hellwig <hch@infradead.org> · 2021-11-02
[PATCH 10/21] iomap: Convert bio completions to use folios · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-11-01
Re: [PATCH 10/21] iomap: Convert bio completions to use folios · Christoph Hellwig <hch@infradead.org> · 2021-11-02
[PATCH 11/21] iomap: Use folio offsets instead of page offsets · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-11-01
Re: [PATCH 11/21] iomap: Use folio offsets instead of page offsets · Christoph Hellwig <hch@infradead.org> · 2021-11-02
[PATCH 12/21] iomap: Convert iomap_read_inline_data to take a folio · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-11-01
Re: [PATCH 12/21] iomap: Convert iomap_read_inline_data to take a folio · Christoph Hellwig <hch@infradead.org> · 2021-11-02
[PATCH 13/21] iomap: Convert readahead and readpage to use a folio · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-11-01
Re: [PATCH 13/21] iomap: Convert readahead and readpage to use a folio · Christoph Hellwig <hch@infradead.org> · 2021-11-02
Re: [PATCH 13/21] iomap: Convert readahead and readpage to use a folio · Matthew Wilcox <willy@infradead.org> · 2021-11-02
[PATCH 14/21] iomap: Convert iomap_page_mkwrite to use a folio · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-11-01
Re: [PATCH 14/21] iomap: Convert iomap_page_mkwrite to use a folio · Christoph Hellwig <hch@infradead.org> · 2021-11-02
[PATCH 15/21] iomap: Convert iomap_write_begin and iomap_write_end to folios · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-11-01
Re: [PATCH 15/21] iomap: Convert iomap_write_begin and iomap_write_end to folios · kernel test robot <hidden> · 2021-11-02
Re: [PATCH 15/21] iomap: Convert iomap_write_begin and iomap_write_end to folios · Christoph Hellwig <hch@infradead.org> · 2021-11-02
Re: [PATCH 15/21] iomap: Convert iomap_write_begin and iomap_write_end to folios · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-02
Re: [PATCH 15/21] iomap: Convert iomap_write_begin and iomap_write_end to folios · Matthew Wilcox <willy@infradead.org> · 2021-11-03
Re: [PATCH 15/21] iomap: Convert iomap_write_begin and iomap_write_end to folios · Matthew Wilcox <willy@infradead.org> · 2021-11-03
[PATCH 16/21] iomap: Convert iomap_write_end_inline to take a folio · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-11-01
Re: [PATCH 16/21] iomap: Convert iomap_write_end_inline to take a folio · Christoph Hellwig <hch@infradead.org> · 2021-11-02
[PATCH 19/21] iomap: Convert iomap_migrate_page to use folios · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-11-01
Re: [PATCH 19/21] iomap: Convert iomap_migrate_page to use folios · Christoph Hellwig <hch@infradead.org> · 2021-11-02
Re: [PATCH 19/21] iomap: Convert iomap_migrate_page to use folios · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-03
Re: [PATCH 19/21] iomap: Convert iomap_migrate_page to use folios · Matthew Wilcox <willy@infradead.org> · 2021-11-06
[PATCH 21/21] xfs: Support multi-page folios · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-11-01
Re: [PATCH 21/21] xfs: Support multi-page folios · Christoph Hellwig <hch@infradead.org> · 2021-11-02
Re: [PATCH 21/21] xfs: Support multi-page folios · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-03
[PATCH 17/21] iomap,xfs: Convert ->discard_page to ->discard_folio · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-11-01
Re: [PATCH 17/21] iomap,xfs: Convert ->discard_page to ->discard_folio · Christoph Hellwig <hch@infradead.org> · 2021-11-02
Re: [PATCH 17/21] iomap,xfs: Convert ->discard_page to ->discard_folio · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-03
[PATCH 18/21] iomap: Convert iomap_add_to_ioend to take a folio · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-11-01
Re: [PATCH 18/21] iomap: Convert iomap_add_to_ioend to take a folio · Christoph Hellwig <hch@infradead.org> · 2021-11-02
Re: [PATCH 18/21] iomap: Convert iomap_add_to_ioend to take a folio · Matthew Wilcox <willy@infradead.org> · 2021-11-02
Re: [PATCH 18/21] iomap: Convert iomap_add_to_ioend to take a folio · Christoph Hellwig <hch@infradead.org> · 2021-11-03
Re: [PATCH 18/21] iomap: Convert iomap_add_to_ioend to take a folio · Matthew Wilcox <willy@infradead.org> · 2021-11-04
Re: [PATCH 18/21] iomap: Convert iomap_add_to_ioend to take a folio · Christoph Hellwig <hch@infradead.org> · 2021-11-04
Re: [PATCH 18/21] iomap: Convert iomap_add_to_ioend to take a folio · Christoph Hellwig <hch@infradead.org> · 2021-11-04
Re: [PATCH 18/21] iomap: Convert iomap_add_to_ioend to take a folio · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-03
Re: [PATCH 18/21] iomap: Convert iomap_add_to_ioend to take a folio · Matthew Wilcox <willy@infradead.org> · 2021-11-04
[PATCH 20/21] iomap: Support multi-page folios in invalidatepage · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-11-01
Re: [PATCH 20/21] iomap: Support multi-page folios in invalidatepage · Christoph Hellwig <hch@infradead.org> · 2021-11-02
Re: [PATCH 20/21] iomap: Support multi-page folios in invalidatepage · "Darrick J. Wong" <djwong@kernel.org> · 2021-11-03

From: Matthew Wilcox <willy@infradead.org>
Date: 2021-11-02 20:25:42
Also in: linux-block, linux-fsdevel, lkml

On Tue, Nov 02, 2021 at 12:13:22AM -0700, Christoph Hellwig wrote:

On Mon, Nov 01, 2021 at 08:39:11PM +0000, Matthew Wilcox (Oracle) wrote:

quoted

+static inline
+void bio_first_folio(struct folio_iter *fi, struct bio *bio, int i)

Please fix the weird prototype formatting here.

I dunno, it looks weirder this way:

-static inline
-void bio_first_folio(struct folio_iter *fi, struct bio *bio, int i)
+static inline void bio_first_folio(struct folio_iter *fi, struct bio *bio,
+               int i)

Anyway, I've made that change, but I still prefer it the way I had it.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help