Re: [PATCH 18/21] iomap: Convert iomap_add_to_ioend to take a folio
From: Christoph Hellwig <hch@infradead.org>
Date: 2021-11-02 07:26:47
Also in:
linux-block, linux-fsdevel, lkml
On Mon, Nov 01, 2021 at 08:39:26PM +0000, Matthew Wilcox (Oracle) wrote:
quoted hunk ↗ jump to hunk
@@ -1431,11 +1428,9 @@ iomap_do_writepage(struct page *page, struct writeback_control *wbc, void *data) * | desired writeback range | see else | * ---------------------------------^------------------| */ - offset = i_size_read(inode); - end_index = offset >> PAGE_SHIFT; - if (page->index < end_index) - end_offset = (loff_t)(page->index + 1) << PAGE_SHIFT; - else { + isize = i_size_read(inode); + end_pos = folio_pos(folio) + folio_size(folio); + if (end_pos - 1 >= isize) {
Looking at the code not part of the context this looks fine. But I really wonder if this (and also the blocks change above) would be better off being split into separate, clearly documented patches. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@lst.de>