On Thu, Oct 14, 2021 at 01:17:55PM -0700, Darrick J. Wong wrote:

From: Darrick J. Wong <djwong@kernel.org>

Years ago when XFS was thought to be much more simple, we introduced
m_ag_maxlevels to specify the maximum btree height of per-AG btrees for
a given filesystem mount.  Then we observed that inode btrees don't
actually have the same height and split that off; and now we have rmap
and refcount btrees with much different geometries and separate
maxlevels variables.

The 'ag' part of the name doesn't make much sense anymore, so rename
this to m_allocbt_maxlevels to reinforce that this is the maximum height

                 ^^
You named it m_alloc_maxlevels....

of the *free space* btrees.  This sets us up for the next patch, which
will add a variable to track the maximum height of all AG btrees.

(Also take the opportunity to improve adjacent comments and fix minor
style problems.)

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 fs/xfs/libxfs/xfs_alloc.c       |   19 +++++++++++--------
 fs/xfs/libxfs/xfs_alloc.h       |    2 +-
 fs/xfs/libxfs/xfs_alloc_btree.c |    4 ++--
 fs/xfs/libxfs/xfs_trans_resv.c  |    2 +-
 fs/xfs/libxfs/xfs_trans_space.h |    2 +-
 fs/xfs/scrub/agheader.c         |    4 ++--
 fs/xfs/scrub/agheader_repair.c  |    4 ++--
 fs/xfs/xfs_mount.h              |    4 ++--
 8 files changed, 22 insertions(+), 19 deletions(-)

Other than that minor nit, the change looks good.

Reviewed-by: Dave Chinner <redacted>
-- 
Dave Chinner
david@fromorbit.com