Re: [PATCH 06/17] xfs: prepare xfs_btree_cur for dynamic cursor heights
From: Dave Chinner <david@fromorbit.com>
Date: 2021-10-14 22:49:56
On Thu, Oct 14, 2021 at 01:17:28PM -0700, Darrick J. Wong wrote:
From: Darrick J. Wong <djwong@kernel.org> Split out the btree level information into a separate struct and put it at the end of the cursor structure as a VLA. Files with huge data forks (and in the future, the realtime rmap btree) will require the ability to support many more levels than a per-AG btree cursor, which means that we're going to create per-btree type cursor caches to conserve memory for the more common case. Note that a subsequent patch actually introduces dynamic cursor heights. This one merely rearranges the structure to prepare for that. Signed-off-by: Darrick J. Wong <djwong@kernel.org> Reviewed-by: Chandan Babu R <redacted> Reviewed-by: Christoph Hellwig <hch@lst.de> --- fs/xfs/libxfs/xfs_alloc.c | 6 +- fs/xfs/libxfs/xfs_bmap.c | 10 +-- fs/xfs/libxfs/xfs_btree.c | 168 +++++++++++++++++++++++---------------------- fs/xfs/libxfs/xfs_btree.h | 33 +++++++-- fs/xfs/scrub/bitmap.c | 22 +++--- fs/xfs/scrub/bmap.c | 2 - fs/xfs/scrub/btree.c | 47 +++++++------ fs/xfs/scrub/trace.c | 4 + fs/xfs/scrub/trace.h | 10 +-- fs/xfs/xfs_super.c | 2 - fs/xfs/xfs_trace.h | 2 - 11 files changed, 167 insertions(+), 139 deletions(-)
LGTM. Reviewed-by: Dave Chinner <redacted> -- Dave Chinner david@fromorbit.com