[PATCH 9/9] new: don't allow new tests in group 'other'
From: "Darrick J. Wong" <djwong@kernel.org>
Date: 2021-09-15 23:43:31
Also in:
fstests
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Darrick J. Wong <djwong@kernel.org> The 'other' group is vaguely defined at best -- other than what? It's not clear what tests belong in this group, and it has become a dumping ground for random stuff that are classified in other groups. Don't let people create new other group tests. Signed-off-by: Darrick J. Wong <djwong@kernel.org> --- new | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/new b/new
index 6b7dc5d4..5cf96c50 100755
--- a/new
+++ b/new@@ -96,9 +96,9 @@ then while true do - echo -n "Add to group(s) [other] (separate by space, ? for list): " + echo -n "Add to group(s) [auto] (separate by space, ? for list): " read ans - [ -z "$ans" ] && ans=other + [ -z "$ans" ] && ans=auto if [ "X$ans" = "X?" ] then echo $(group_names)
@@ -109,6 +109,9 @@ then echo "Invalid characters in group(s): $inval" echo "Only lower cases, digits and underscore are allowed in groups, separated by space" continue + elif echo "$ans" | grep -q -w "other"; then + echo "Do not add more tests to group \"other\"." + continue else # remove redundant spaces/tabs ans=`echo "$ans" | sed 's/\s\+/ /g'`