Thread (32 messages) 32 messages, 3 authors, 2021-02-26

Re: [PATCH 06/13] xfs: move log iovec alignment to preparation function

From: Christoph Hellwig <hch@infradead.org>
Date: 2021-02-25 09:43:08

On Wed, Feb 24, 2021 at 05:34:52PM +1100, Dave Chinner wrote:
From: Dave Chinner <redacted>

To include log op headers directly into the log iovec regions that
the ophdrs wrap, we need to move the buffer alignment code from
xlog_finish_iovec() to xlog_prepare_iovec(). This is because the
xlog_op_header is only 12 bytes long, and we need the buffer that
the caller formats their data into to be 8 byte aligned.

Hence once we start prepending the ophdr in xlog_prepare_iovec(), we
are going to need to manage the padding directly to ensure that the
buffer pointer returned is correctly aligned.

Signed-off-by: Dave Chinner <redacted>
Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help