Re: [PATCH 02/13] xfs: only CIL pushes require a start record
From: Christoph Hellwig <hch@infradead.org>
Date: 2021-02-25 09:20:53
quoted hunk ↗ jump to hunk
diff --git a/fs/xfs/xfs_log_cil.c b/fs/xfs/xfs_log_cil.c index e8c674b291f3..145f1e847f82 100644 --- a/fs/xfs/xfs_log_cil.c +++ b/fs/xfs/xfs_log_cil.c@@ -652,14 +652,22 @@ xlog_cil_process_committed( } struct xlog_cil_trans_hdr { + struct xlog_op_header oph[2]; struct xfs_trans_header thdr; - struct xfs_log_iovec lhdr; + struct xfs_log_iovec lhdr[2];
oph and lhdr aren't really used as individual arrays. What about splitting them into separate fields and giving them descriptive names?