Re: [PATCH 1/4] xfs_repair: set NEEDSREPAIR the first time we write to a filesystem
From: Christoph Hellwig <hch@infradead.org>
Date: 2021-02-25 08:18:13
quoted hunk ↗ jump to hunk
diff --git a/include/xfs_mount.h b/include/xfs_mount.h index 75230ca5..f93a9f11 100644 --- a/include/xfs_mount.h +++ b/include/xfs_mount.h@@ -11,6 +11,8 @@ struct xfs_inode; struct xfs_buftarg; struct xfs_da_geometry; +typedef void (*buf_writeback_fn)(struct xfs_buf *bp);
Any point in adding a typedef that is only used once?
+ if (!bp || bp->b_error) {
+ do_log(
+ _("couldn't get superblock to set needsrepair, err=%d\n"),
+ bp ? bp->b_error : ENOMEM);Maybe add a goto out_buf_release goto here to avoid the extra level of indentation for the normal path? But the code itself looks good, so: Reviewed-by: Christoph Hellwig <hch@lst.de>