Re: [PATCH 4/4] xfs_repair: add post-phase error injection points
From: Allison Henderson <hidden>
Date: 2021-02-24 05:40:46
On 2/22/21 8:01 PM, Darrick J. Wong wrote:
From: Darrick J. Wong <djwong@kernel.org> Create an error injection point so that we can simulate repair failing after a certain phase. Signed-off-by: Darrick J. Wong <djwong@kernel.org> Reviewed-by: Eric Sandeen <redacted> Reviewed-by: Brian Foster <redacted>
Looks fine Reviewed-by: Allison Henderson <redacted>
quoted hunk ↗ jump to hunk
--- repair/globals.c | 3 +++ repair/globals.h | 3 +++ repair/xfs_repair.c | 8 ++++++++ 3 files changed, 14 insertions(+)diff --git a/repair/globals.c b/repair/globals.c index 110d98b6..537d068b 100644 --- a/repair/globals.c +++ b/repair/globals.c@@ -117,3 +117,6 @@ uint64_t *prog_rpt_done; int ag_stride; int thread_count; + +/* If nonzero, simulate failure after this phase. */ +int fail_after_phase;diff --git a/repair/globals.h b/repair/globals.h index 1d397b35..a9287320 100644 --- a/repair/globals.h +++ b/repair/globals.h@@ -162,4 +162,7 @@ extern uint64_t *prog_rpt_done; extern int ag_stride; extern int thread_count; +/* If nonzero, simulate failure after this phase. */ +extern int fail_after_phase; + #endif /* _XFS_REPAIR_GLOBAL_H */diff --git a/repair/xfs_repair.c b/repair/xfs_repair.c index a9236bb7..64d7607f 100644 --- a/repair/xfs_repair.c +++ b/repair/xfs_repair.c@@ -362,6 +362,10 @@ process_args(int argc, char **argv) if (report_corrected && no_modify) usage(); + + p = getenv("XFS_REPAIR_FAIL_AFTER_PHASE"); + if (p) + fail_after_phase = (int)strtol(p, NULL, 0); } void __attribute__((noreturn))@@ -853,6 +857,10 @@ static inline void phase_end(int phase) { timestamp(PHASE_END, phase, NULL); + + /* Fail if someone injected an post-phase error. */ + if (fail_after_phase && phase == fail_after_phase) + platform_crash(); } int