On 8/15/17 5:14 AM, Jan Tulak wrote:

On Tue, Aug 15, 2017 at 1:07 AM, Darrick J. Wong
[off-list ref] wrote:

quoted

On Fri, Aug 11, 2017 at 02:30:36PM +0200, Jan Tulak wrote:

quoted

Move getnum, check_opt and illegal_option within the file. We have to do
this to avoid dependency issues with the following patch. There is no
other change in this patch, just cut&paste of these functions.

Signed-off-by: Jan Tulak <redacted>
---
 mkfs/xfs_mkfs.c | 236 ++++++++++++++++++++++++++++----------------------------
 1 file changed, 118 insertions(+), 118 deletions(-)

diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index e3f7d345..3e7ba5f0 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c

@@ -813,6 +813,124 @@ get_conf_raw_safe(const int opt, const int subopt)
      return str;
 }

+static __attribute__((noreturn)) void
+illegal_option(

How about declaring the functions at the top and leaving the definitions
where they are?

If I remember, Eric thought the opposite. :-)

I don't remember, but at this point I'm ok with whatever, this part
just isn't that important.

Thanks,
-Eric