Thread (37 messages) 37 messages, 4 authors, 2017-08-17

Re: [PATCH 3/6 v2] mkfs: remove intermediate getstr followed by getnum

From: Eric Sandeen <hidden>
Date: 2017-08-15 23:20:12

On 8/15/17 10:08 AM, Jan Tulak wrote:
Some options loaded a number as a string with getstr and converted it to
number with getnum later in the code, without any reason for this
approach.  (They were probably forgotten in some past cleaning.)

This patch changes them to skip the string and use getnum directly in
the main option-parsing loop, as do all the other numerical options.
And as we now have two variables of the same type for the same value,
merge them together. (e.g. former string dsize and number dbytes).

Signed-off-by: Jan Tulak <redacted>

---
UPDATE:
* in getnum: set_conf_raw -> set_conf_raw_safe
Looks fine, though if you take my advice on patch1, it'll
be set_conf_raw_safe -> set_conf_raw again ;)

-Eric
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help