Il 13/06/2012 05:30, Dave Chinner ha scritto:

quoted

quoted

Also, a minor nit, but you should credit where this code has
originated from in the commit messages, and describe the use case
for requiring it. i.e. based on:

http://permalink.gmane.org/gmane.linux.file-systems/62449

Interesting, I didn't know this---I wrote the code from scratch.

I took the description from the man pages ("This operation is a fast
method of overwriting any from the range specified with zeros without
removing any blocks or having to write zeros to disk"), so perhaps those
will have to be patched as well.

Oh, and you'll need to provide a new xfstests test based on 242 that
uses the new fallocate interface, and to do that you'll also need to
add support for the new fallocate function in xfs_io.

Sure.  Thanks for the hints, I'll submit a v2 (may take a while as I'll
leave for holiday soon).

Paolo

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs