Re: [PATCH v5 1/5] wifi: nl80211: add roam offload extended feature
From: Arend van Spriel <arend.vanspriel@broadcom.com>
Date: 2026-08-30 09:14:16
Also in:
lkml
On 22/08/2026 20:36, Arend van Spriel wrote:
On 21/08/2026 09:56, Jason Huang wrote:quoted
From: Carella Chen <redacted> Drivers can offload FT or OKC roaming without necessarily advertising full 802.1X 4-way handshake offload. Add an extended feature bit for that capability and allow PMK configuration when it is present. This gives userspace a way to provide PMK or PMK-R0 material needed by firmware roaming implementations while keeping the existing 4-way handshake offload capability unchanged. Assisted-by: GitHub-Copilot-CLI:gpt-5.5 Signed-off-by: Carella Chen <redacted> Signed-off-by: Jason Huang <redacted> --- include/uapi/linux/nl80211.h | 4 ++++ net/wireless/nl80211.c | 7 +++++-- 2 files changed, 9 insertions(+), 2 deletions(-)
[...]
quoted
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 44f2bad08670..15731440c57a 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c@@ -18434,6 +18434,7 @@ static intnl80211_set_multicast_to_unicast(struct sk_buff *skb, static int nl80211_set_pmk(struct sk_buff *skb, struct genl_info *info) { struct cfg80211_registered_device *rdev = info->user_ptr[0]; + struct wiphy *wiphy = &rdev->wiphy; struct net_device *dev = info->user_ptr[1]; struct wireless_dev *wdev = dev->ieee80211_ptr; struct cfg80211_pmk_conf pmk_conf = {};@@ -18442,8 +18443,10 @@ static int nl80211_set_pmk(struct sk_buff*skb, struct genl_info *info) wdev->iftype != NL80211_IFTYPE_P2P_CLIENT) return -EOPNOTSUPP; - if (!wiphy_ext_feature_isset(&rdev->wiphy, - NL80211_EXT_FEATURE_4WAY_HANDSHAKE_STA_1X)) + if (!wiphy_ext_feature_isset(wiphy, + NL80211_EXT_FEATURE_4WAY_HANDSHAKE_STA_1X) && + !wiphy_ext_feature_isset(wiphy, + NL80211_EXT_FEATURE_ROAM_OFFLOAD))Ah. _FAST_ROAM_OFFLOAD is not longer than the other ext_feature checked here.
Actually there is a checkpatch warning that line with the STA_1X check is 82 characters. So my suggestion please make it FAST_ROAMING instead of ROAM_OFFLOAD and swap the two checks to fix the checkpatch warning. Regards, Arend