Re: [PATCH v2 2/2] mwifiex: Try waking the firmware until we get an interrupt

[PATCH v2 0/2] mwifiex: Work around firmware bugs on 88W8897 chip · Jonas Dreßler <hidden> · 2021-09-14
[PATCH v2 1/2] mwifiex: Use non-posted PCI write when setting TX ring write pointer · Jonas Dreßler <hidden> · 2021-09-14
Re: [PATCH v2 1/2] mwifiex: Use non-posted PCI write when setting TX ring write pointer · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-09-22
Re: [PATCH v2 1/2] mwifiex: Use non-posted PCI write when setting TX ring write pointer · Jonas Dreßler <hidden> · 2021-09-22
Re: [PATCH v2 1/2] mwifiex: Use non-posted PCI write when setting TX ring write pointer · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-09-22
RE: [PATCH v2 1/2] mwifiex: Use non-posted PCI write when setting TX ring write pointer · David Laight <hidden> · 2021-09-22
Re: [PATCH v2 1/2] mwifiex: Use non-posted PCI write when setting TX ring write pointer · Pali Rohár <pali@kernel.org> · 2021-09-22
RE: [PATCH v2 1/2] mwifiex: Use non-posted PCI write when setting TX ring write pointer · David Laight <hidden> · 2021-09-22
Re: [PATCH v2 1/2] mwifiex: Use non-posted PCI write when setting TX ring write pointer · Jonas Dreßler <hidden> · 2021-09-30
Re: [PATCH v2 1/2] mwifiex: Use non-posted PCI write when setting TX ring write pointer · Jonas Dreßler <hidden> · 2021-10-06
[PATCH v2 2/2] mwifiex: Try waking the firmware until we get an interrupt · Jonas Dreßler <hidden> · 2021-09-14
Re: [PATCH v2 2/2] mwifiex: Try waking the firmware until we get an interrupt · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-09-22
Re: [PATCH v2 2/2] mwifiex: Try waking the firmware until we get an interrupt · Jonas Dreßler <hidden> · 2021-09-30
Re: [PATCH v2 2/2] mwifiex: Try waking the firmware until we get an interrupt · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-09-30
Re: [PATCH v2 2/2] mwifiex: Try waking the firmware until we get an interrupt · Jonas Dreßler <hidden> · 2021-09-30
Re: [PATCH v2 2/2] mwifiex: Try waking the firmware until we get an interrupt · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-09-30
Re: [PATCH v2 2/2] mwifiex: Try waking the firmware until we get an interrupt · Jonas Dreßler <hidden> · 2021-10-03
Re: [PATCH v2 2/2] mwifiex: Try waking the firmware until we get an interrupt · Brian Norris <briannorris@chromium.org> · 2021-10-04
Re: [PATCH v2 0/2] mwifiex: Work around firmware bugs on 88W8897 chip · Brian Norris <briannorris@chromium.org> · 2021-09-27

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2021-09-30 21:16:38
Also in: linux-pci, lkml, netdev, stable

On Thu, Sep 30, 2021 at 11:07:09PM +0200, Jonas Dreßler wrote:

On 9/30/21 10:58 PM, Andy Shevchenko wrote:

quoted

On Thu, Sep 30, 2021 at 08:04:00PM +0200, Jonas Dreßler wrote:

...

quoted

Second, what is the problem with having one write more or less?
Your current code doesn't guarantee this either. It only decreases
probability of such scenario. Am I wrong?

Indeed my approach just decreases the probability and we sometimes end up
writing twice to wakeup the card, but it would kinda bug me if we'd always
do one write too much.

Anyway, if you still prefer the read_poll_timeout() solution I'd be alright
with that of course.

Yes, it will make code cleaner.

-- 
With Best Regards,
Andy Shevchenko

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help