Thread (11 messages) 11 messages, 3 authors, 2021-09-28

Re: [PATCH 4/4] ath11k: add caldata download support from EEPROM

From: Kalle Valo <hidden>
Date: 2021-09-28 09:26:17
Also in: ath11k

Anilkumar Kolli [off-list ref] writes:
On 2021-09-24 20:34, Kalle Valo wrote:
quoted
Jouni Malinen [off-list ref] writes:
quoted
From: Anilkumar Kolli <redacted>

Firmware updates EEPROM support capability in QMI FW caps, send QMI
BDF
download request message with file type EEPROM, to get caldata
download
from EEPROM. Firmware takes more time to update cal data from
EEPROM, so
increase QMI timeout.
The commit log would need more explanation how this patch works.
FW advertizes calibration data support from EEPROM through
'eeprom_read_timeout' in QMI FW Capability message. Ath11k sends BDF
download request with file type 'ATH11K_QMI_FILE_TYPE_EEPROM'. FW has
logic to read calibration data from EEPROM and process the calibration
data. FW takes more time to process the calibration data from EEPROM
so increase QMI timeout to 10msec.
Thanks, I now copied the updated commit log below. And do note that the
timeout is 10 s, not 10 ms.

    ath11k: add caldata download support from EEPROM
    
    In some devices the calibration data is stored to EEPROM within the device so add
    support for that.
    
    The firmware advertises the calibration data support from EEPROM through
    'eeprom_read_timeout' in the QMI firmware capability message. ath11k sends
    boardfile download request with file type 'ATH11K_QMI_FILE_TYPE_EEPROM'. The
    firmware has logic to read calibration data from EEPROM and process the
    calibration data.
    
    As now the firmware takes more time to process the calibration data from EEPROM
    so increase QMI timeout to 10 seconds.
    
    Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.4.0.1-01838-QCAHKSWPL_SILICONZ-1


-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help