On 2021-08-13 15:19, Johannes Berg wrote:

On Fri, 2021-07-30 at 18:47 +0800, Wen Gong wrote:

quoted

quoted

And then two more questions:

1) Could this information change? Should we track it in beacons?

The information is from AP side, it should be not changed untill the 
AP
restart.
If someone want to change configure of AP, the AP should restart and
then take effect by my understand.
Is it have some case for this information change?

No, I guess that's fine then, I just didn't know.

quoted

quoted

2) Should we at least check it again from the protected beacon or such
after association, so we don't blindly trust the probe response or
beacon (received during scan, not validated) at least when BIGTK is in
use?

May we add support for BIGTK in future with another patch?

We already have BIGTK support in mac80211, so if we don't do that now
we're almost certainly not going to do it, so I'd really prefer if you
did it here, or if a separate patch still did it now.

quoted

The info(pwr_reduction and tx_pwr_env) is used by lower driver such as
ath11k.

Sure.

quoted

If the info changed after association, then how to notify lower 
driver?
Do it like below in ieee80211_rx_mgmt_beacon()?
And use BSS_CHANGED_TXPOWER or a new enum in ieee80211_bss_change?

Yeah, dunno. Are the drivers assuming now it's set once you get to
associated state?

yes, driver need this info while associate process.

johannes