On 2021-07-23 17:24, Johannes Berg wrote:

On Mon, 2021-05-17 at 16:19 -0400, Wen Gong wrote:

quoted

+ * @IEEE80211_CHAN_PSD: power spectral density (in dBm)
+ *	on this channel.

Do we need that? Which really is just another way of asking

quoted

+ * @psd: power spectral density (in dBm)

whether or not 0 is a valid value for this?

yes, 0 is also a valid value.
It also have negative, such as -1dBm.

quoted

+++ b/include/uapi/linux/nl80211.h

@@ -4040,6 +4040,7 @@ enum nl80211_sched_scan_match_attr {

  * @NL80211_RRF_NO_80MHZ: 80MHz operation not allowed
  * @NL80211_RRF_NO_160MHZ: 160MHz operation not allowed
  * @NL80211_RRF_NO_HE: HE operation not allowed
+ * @NL80211_RRF_PSD: channels has power spectral density value

It doesn't seem like we need this, after all, there must be some kind 
of
attribute for the PSD, and then its presence/absence already indicates
this?

Now the psd value 0 is also a valid value, so now we can not consider 
the
psd 0 as NON-PSD, so we need this flag to check it is psd or NON-psd.

johannes