Re: [PATCH 00/18] use semicolons rather than commas to separate statements
From: Julia Lawall <julia.lawall@inria.fr>
Date: 2020-09-29 13:42:47
Also in:
kernel-janitors, linux-acpi, linux-amlogic, linux-arm-kernel, linux-block, linux-clk, linux-crypto, linux-ide, linux-iio, lkml
On Tue, 29 Sep 2020, Joe Perches wrote:
On Tue, 2020-09-29 at 14:47 +0200, Julia Lawall wrote:quoted
On Tue, 29 Sep 2020, Dan Carpenter wrote:quoted
The times where commas are used deliberately to replace curly braces are just evil. Either way the code is cleaner with semi-colons.I also found exaamples like the following to be particularly unforunate: fprintf(stderr, "page_nr %lu wrong count %Lu %Lu\n", page_nr, count, count_verify[page_nr]), exit(1); The exit is very hard to see, unless you know to look for it.I sent that patch last month. https://patchwork.kernel.org/patch/11734877/ It's still not applied.
OK, thanks. I'll not send those then :) julia