Re: [PATCH 00/18] use semicolons rather than commas to separate statements
From: Dan Carpenter <hidden>
Date: 2020-09-29 12:43:17
Also in:
kernel-janitors, linux-acpi, linux-amlogic, linux-arm-kernel, linux-block, linux-clk, linux-crypto, linux-ide, linux-iio, lkml
On Tue, Sep 29, 2020 at 02:20:00PM +0200, Ard Biesheuvel wrote:
On Sun, 27 Sep 2020 at 21:56, Julia Lawall [off-list ref] wrote:quoted
These patches replace commas by semicolons.Why?
In the best case, these commas are just uninitentional mess, like typing
an extra space character or something. I've looked at them before and
one case I see where they are introduced is when people convert a
struct initializer to code.
- struct foo {
- .a = 1,
- .b = 2,
...
+ foo.a = 1,
+ foo.b = 2,
The times where commas are used deliberately to replace curly braces are
just evil. Either way the code is cleaner with semi-colons.
regards,
dan carpenter